search

brasky / pythonorbit

Orbit is a cryptocurrency triangular arbitrage bot that is no longer being used/developed and thus has been made public.
0 stars 0 forks source link

ETH Markets: funny issue with specific pairs #2

Closed colinkimball closed 6 years ago

colinkimball commented 6 years ago

The way that we are matching BNB base markets to BTC based markets is by saying: if bnbcoins['symbol'][:-3] in allcoins['symbol']:

We will need to change this for ETH Markets OSTETH and IOSTETH are coins, and VIBETH and VIBEETH are coins. OST is in IOST, and VIB is in VIBE, so there is a mismatch. When I saw a profitability index calc of 1.17 on VIBETH I knew it was too good to be true, likewise when I saw a calc of 0.17 on OSTETH I knew something was wrong. since BNB markets only have OST and VIB (not the others), we didn't run into that issue before.

colinkimball commented 6 years ago

Fixed easily by: if ETHcoins['symbol'][:-3] == allcoins['symbol'][:-3]:

just thought it was interesting enough to merit a comment