brasslock / rubyripper

Automatically exported from code.google.com/p/rubyripper
1 stars 0 forks source link

CCDB-request at freedb fails if flactac is installed #557

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
1) Please describe the steps to reproduce the situation:
a.install flactag
b.try to fetch cddb information from freedb

2) What is the expected output? What do you see instead?

Instead of the expected information i get this: ccdb_query Rückgabewert = 500. 
Rückgabewert nicht unterstützt.
This is what I see in a terminal: 
$ rrip_gui
preparing to contact freedb server
cddb query 1 = 
/~cddb/cddb.cgi?cmd=cddb+query+BU5NbSAbYr4TKvppwskrOqm_COE-&hello=anonymous+my_s
ecret.com+rubyripper+0.6.2&proto=6
Created query string: 
/~cddb/cddb.cgi?cmd=cddb+query+BU5NbSAbYr4TKvppwskrOqm_COE-&hello=anonymous+my_s
ecret.com+rubyripper+0.6.2&proto=6

3) What version of rubyripper are you using? On what operating system? The
gtk2 of commandline interface?

0.6.2 gui from deb-multimedia.org. But also happens with the 0.6.2 directly 
loaded from this page.
Im using debian unstable.

4) Is this not already fixed with the latest & greatest code? See for
instructions the Source tab above.

Tried the last git-version, but this had also problems fetching 
cddb-information.

5) Does the problem happen with all discs? If not, please attach
the output of cdparanoia -Q with a disc that gives trouble.

Yes

Someone at debianforum.de discovered that this is a issue with cd-discid and 
flactag and can be solved by removing flactag.

--------------Quote----------
$ cat /usr/lib/rubyripper/rr_lib.rb
[...]
def getFreedbString
if installed('discid')
if RUBY_PLATFORM.include?('darwin') ; `diskutil unmount #{@cdrom}` end
@freedbString = `discid #{@cdrom}`
if RUBY_PLATFORM.include?('darwin') ; `diskutil mount #{@cdrom}` end
elsif installed('cd-discid') # if no discid exists, try cd-discid
@freedbString = `cd-discid #{@cdrom}`
else # if both do not exist generate it ourselves (less foolproof)
puts _("warning: discid or cd-discid isn't found on your system! Using 
fallback...")
checkDataTrack()
createFreedbString()
puts _("freedb string = %s" % [@freedbString])
end
@discId = @freedbString.split()[0]
end
[...]

$ apt-file search /usr/bin/discid
flactag: /usr/bin/discid

$ apt-file search /usr/bin/cd-discid
cd-discid: /usr/bin/cd-discid

--------------Quote----------

https://debianforum.de/forum/viewtopic.php?f=25&t=140265&p=913863#p913826

Original issue reported on code.google.com by mdosch...@gmail.com on 20 Jan 2013 at 11:25

GoogleCodeExporter commented 9 years ago
It seems to me that your distro is messing up with the binaries. If they 
install a program "flactag" as "discid" that is strange, isn't it? I suggest 
you file a bug at your distro or indeed uninstall the flactag program.

The discid binary should be reserved for this project instead: 
http://discid.sourceforge.net/

Original comment by boukewou...@gmail.com on 24 Jan 2013 at 7:05

GoogleCodeExporter commented 9 years ago
Problem is that in rr_lib.rb, the 'discid' binary is searched for first, and 
that one belongs to the flactag debian package...
Swapping these should resolve the problem..
i.e.
-if installed('discid')
+if installed('cd-discid')
-elsif installed('cd-discid')
+elsif installed('discid')
without side effects on Mac?

Original comment by empee584 on 7 Oct 2013 at 1:54