brata-hsdc / brata.masterserver

Behind-the-scenes coordination and support for the HSDC
Apache License 2.0
1 stars 0 forks source link

return tied to settings, and settings changed to support easier retur… #67

Closed jaron42 closed 8 years ago

jaron42 commented 8 years ago

…n retrieval

ellerychan commented 8 years ago

@jaron42 A couple of style comments:

Instead of this (file piservice/views.py, lines 1021, 1568):

"return_guidance_pattern": [params[0], params[1], params[2], params[3], params[4], params[5]],

You could do this:

"return_guidance_pattern": params[0:6],

or in this case you could also do just:

"return_guidance_pattern": params,