search

brata-hsdc / brata.station

Automatically exported from code.google.com/p/brata.station
Apache License 2.0
0 stars 0 forks source link

ConnectionManager does not call join periodically #12

Open jawaad-ahmad opened 9 years ago

jawaad-ahmad commented 9 years ago

The ConnectionManager was supposed to periodically call join on the Master Server in order to implement a heartbeat. It looks like this was never coded.

This continues brata-hsdc/brata#53.

DragonmasterJ commented 9 years ago

@jawaad-ahmad Didn't we dig into the code looking for this last year? I thought we had coded it, but was waiting on testing it with the MS. Do you have any faint memories of that?

ellerychan commented 9 years ago

This brings two things to mind.

  1. Maybe someone should open an issue regarding changing the message formats on the station to match what we are putting together on the MS.
  2. This is probably a good reason to push forward with putting together the standalone MS configuration, as it can log join messages and could help with debugging.
jawaad-ahmad commented 9 years ago
  1. We don't know which ones yet till we get further into the spec. I've been working on that since Thu's meeting and will do some more today. I recommend waiting and we can open the issues later when we understand better what needs changing. This is something we won't forget about.
  2. I'm unclear on what you're stating needs to be done here. Are you suggesting we focus on the standalone setup first rather than as an afterthought?
ellerychan commented 9 years ago

Maybe I'm stating the obvious: that the MS could be useful to people debugging the station software, so we should make sure it works in the standalone configuration as soon as a minimal working set of functionality is available, rather than wait until the implementation is mature and complete before doing so.

ellerychan commented 8 years ago

See comments in #11 ConnectionManager blocks.