search

brata-hsdc / brata

Automatically exported from code.google.com/p/brata
2 stars 0 forks source link

Does CTS need to handle onPassed, onFailed? #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Do we need to implement actions for the onPassed and onFailed events in CTS?  
When would those events be received and what should be done?  Perhaps the MS 
sends them and we need to update the display...

Original issue reported on code.google.com by ellery.c...@gmail.com on 13 Dec 2014 at 6:03

GoogleCodeExporter commented 9 years ago 
Is this related to Issue #7?

Original comment by ellery.c...@gmail.com on 15 Dec 2014 at 1:27

GoogleCodeExporter commented 9 years ago

Original comment by ellery.c...@gmail.com on 27 Dec 2014 at 9:34

GoogleCodeExporter commented 9 years ago 
Pushed changes that add timed message display states to the onPassed and 
onFailed handlers.  Not tested because I don't know how to invoke the onPassed 
or onFailed handlers.  But the changes should be isolated and not affect other 
functionality.  Updated CTS State Diagram (see attached PDF).

Original comment by ellery.c...@gmail.com on 8 Jan 2015 at 7:25

Attachments:

GoogleCodeExporter commented 9 years ago 
In order to try this out standalone (i.e. without any MS), you can launch the 
four windows described at the bottom of the GUB.

Then, in Window 3, run the curl command for start_challenge. This will allow 
the CTS to accept a combo.

When you press the Enter/Select button twice, I think you'll invoke 
handleSubmission in connection.py, followed by handleSubmissionResp. The latter 
sets _callback.State, which is a property in main.py.

Setting the State calls the property setter, which calls onPassed or onFailed.

Depending on how much is coded for CTS, either onFailed will always get called 
no matter what, or the right method will get called as expected. (From what I 
recall I think enough is coded for you to get the right one called.

Original comment by jawaad.a...@gmail.com on 15 Jan 2015 at 12:05

GoogleCodeExporter commented 9 years ago 
Added some more states to the display output.  Mostly added more timed messages 
to tell the user a better story.

Tested about as well as I can without a real MS.

Original comment by ellery.c...@gmail.com on 28 Jan 2015 at 8:12

GoogleCodeExporter commented 9 years ago

Original comment by jawaad.a...@gmail.com on 19 Feb 2015 at 12:39