bratislava / component-library

WIP - repo that should contain all the necessary parts of the future component library
0 stars 0 forks source link

Feature/5/chip component #9

Open ValkovMirec opened 7 months ago

ValkovMirec commented 7 months ago

-created style guide page in kupaliska project and imported Tag preview

kupaliskaBaTagPreview

It seems that component from our library works without aria/aria-components update as intended.

Only thing left to do is to rebase it onto Typography component when ready and use Typography inside of our TagGroup, push it whole to npm and install it to projects/import it instead of yalc.

ValkovMirec commented 7 months ago

I've done some types cleanup and renaming and used Typography component, but waiting on response from Patrik because of only font type from Typograhy that is fine in size is paragraph, which i doubt we want to use. So I've asked him if I can add new variants of span to satisfy needs of Chip component.

EDIT: After conversation with Patrik, I've added normal span font so Chips can look according to Figma design. I've added TSdoc comment and cleaned up unused classes