Main menu screen & bug fixes - Githubissues

bratislava / paas-mpa

European Union Public License 1.2

1 stars 0 forks source link

Main menu screen & bug fixes #298

Closed lukybil closed 5 months ago

lukybil commented 5 months ago

resolved comments from the previous PR (I did not change the SearchContext because I did not want to end up with a function setSetFlyToCenter, I can update it if necessary)
220 newlines in markdown fix
272 navigate to current location button: If permission is denied, the button is hidden, if location service is off, after pressing the button, location should be requested to be turned on
241 main menu as screen
231 text overlap fix

Points for a discussion:

Should the main menu have a fixed distance?
What should be the size of the spacer on the left? Right now the menu has a min width and is set to flex grow
Should the spacer be a backdrop? Should it have a lets say rgba(0,0,0,0.5) background?

radoslavzeman commented 5 months ago

Questions can be addressed in Figma and solved as separate PR.

radoslavzeman commented 5 months ago

Safe view should be used in multiple places, it's a good point, but I would keep it as separate issue.