braun-steven / simple-einet

An implementation of EinsumNetworks in PyTorch.
MIT License
18 stars 6 forks source link

Small Patch #2

Closed felixdivo closed 2 years ago

felixdivo commented 2 years ago

This PR:

If any change is not wanted, just say so and I'll remove it. The example code from the README is btw. duplicated in einet.py (at the bottom of the file). I guess one could remove it from there or also apply the patch to that part.

felixdivo commented 2 years ago

CC @steven-lang

felixdivo commented 2 years ago

If the changes are still wanted, I can offer to resolve the conflicts.

braun-steven commented 2 years ago

Absolutely - the PR is great, I just didn't have the time to resolve and merge it yet. I will probably find time on Friday, but if you want to, feel free to resolve the conflicts and I'm happy to merge it afterward.

felixdivo commented 2 years ago

I'll have a look later this day

felixdivo commented 2 years ago

@steven-lang should be done

felixdivo commented 2 years ago

I tested that examples/test_iris.py still runs.