search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Left anchor filters do not support wildcards #136

Open bbondy opened 5 years ago

bbondy commented 5 years ago

Currently left anchored filters only support exact matches. Should they support wildcards? There are some easylist rules (a few) which do that.

bjb568 commented 5 years ago

An example from EazyPrivacy is ||fls-*.amazon.*%1 which should be matched by this URL:

https://fls-na.amazon.com/1/action-impressions/1/OE/aws-mktg/action/awsm_v2_:perf_windowLoad@v=1815:u=ms/awsm_v2_:perf_loadEventEnd@v=1805:u=ms/awsm_v2_:perf_domComplete@v=1791:u=ms?dataset=LIVE%3APROD&instance=LIVE&service=awsm&marketplace=en_US&client=dsk&host=aws.amazon.com&marketplaceId=A12QK8IU0H0XW5&requestId=ABCDEFGHIJKLMNOPQRST&session=123-1234567-1234567

(I'm working with @snyderp this summer.)

pes10k commented 5 years ago

I think there might have been a copy-paste error in the above. The filter rule is ||fls-*.amazon.*% (no trailing 1

bbondy commented 5 years ago

oh I think there is just no wildcards in the host supported. But that seems like a different issue than the left anchored filters

bbondy commented 5 years ago

This repo is basically deprecated though in favour of brave/adblock-rust

pes10k commented 5 years ago

Thanks @bbondy. Working with @AndriusA to get this parsed right in the new one. Will focus attention there going forward.