search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Add "Malware Domain List" and "Malware domains" to malware_lists #142

Closed rht closed 5 years ago

rht commented 5 years ago

There could be perf concerns for having too big of a list, but these additional sources should be available as an option for those who prefer the blocking to be as comprehensive as uBlock Origin. Based on https://github.com/gorhill/uBlock/blob/e37cc238a772b1e51d9b2e2ea7ab33b14a12dc64/assets/assets.json#L171-L194.

rht commented 5 years ago

(How do I disable the 2 newly added sources?)

bbondy commented 5 years ago

@rht Sorry for not noticing this PR sooner. If you want an invite to our Slack in a guest channel please shoot me an email at brian@brave.com and then you can ping for any PR that takes too long. Sorry if you're already there and I'm not matching up your username.

diracdeltas commented 5 years ago

does this mean domains from these lists will be blocked by default? (or is it opt-in?)

i think we want to make sure that these list maintainers have some reasonable guards against false positives, otherwise legit sites could end up being blocked. for instance https://www.malwaredomains.com/?p=4168

BTW the spam404 list was originally because we didn't have safebrowsing integrated; now that we do, it may no longer be necessary

bbondy commented 5 years ago

I think we're only using these lists in mobile today. If at all.

fmarier commented 5 years ago

I think we're only using these lists in mobile today. If at all.

@diracdeltas and I tested this yesterday and these lists are currently used only on iOS. I opened https://github.com/brave/browser-android-tabs/issues/1212 for Android.

diracdeltas commented 5 years ago

@rht On second thought, we decided not to add any more third-party lists for malware protection and may even filter out some of the existing entries to reduce the risk of false positives. We may revisit this decision in the future. Thanks anyway for the PR though!