search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Brave's ad-block's region_list is not as complete as uBO's #146

Open rht opened 5 years ago

rht commented 5 years ago

Missing regions are NOR, ROU, POR, and THA.

krystian3w commented 4 years ago

Also Polish moved anti-adblock filters to other repository:

https://github.com/olegwukr/polish-privacy-filters/blob/master/anti-adblock.txt https://github.com/olegwukr/polish-privacy-filters/blob/master/anti-adblock-suplement.txt

pes10k commented 4 years ago

I defer to @ryanbr if we should pull in new lists. If he says so, this is 👍 from me.

@ryanbr what do you think?

ryanbr commented 4 years ago

Okay, will look through these lists. Some are very specific to uBO (which won't work in Brave Release)

ryanbr commented 4 years ago

I don't see an issue with it, though applying possibly all separate Anti-adblock lists for all languages would make brave://adblock much larger (which may need to reorganise if got too large). But as its stands, it's fine to include. I can patch this in this week.

pes10k commented 4 years ago

@ryanbr sounds good! If you need any help handling, let me know. Also, @bbondy , is it alright ot add these additional languages in?

bbondy commented 4 years ago

you can go ahead and add more languages 👍

pes10k commented 4 years ago

terrific! @ryanbr if you need any help with this let me know. Otherwise, looks like you're good to go!

krystian3w commented 4 years ago

Also see this: https://github.com/brave/adblock-lists/issues/334

Prebake is unsupported (the repository has been archived and has not been updated for several years), no block many cookies bars / popups and possible generate breakge.

https://github.com/brave/ad-block/blob/0a03587e37990ea5c22abca798d8c63da06bf3e3/lists/regions.h#L88

ryanbr commented 4 years ago

@krystian3w Yeah, we're aware of it. https://github.com/brave/adblock-rust/pull/67 (WIP)