search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Check.js Incorrect handling of 1p and 3p exception rules #166

Closed pes10k closed 5 years ago

pes10k commented 5 years ago

The following doesn't seem quite right:

~/C/ad-block (master)❯ node scripts/check.js --host batcommunity.org --location https://analytics.brave.com/piwik.js -D
params: https://analytics.brave.com/piwik.js 0 batcommunity.org
{ matches: false,
  matchingFilter: 'analytics.brave.com^',
  matchingOrigRule: '||analytics.brave.com^',
  matchingExceptionFilter: 'https://analytics.*/piwik.',
  matchingExceptionOrigRule: '@@https://analytics.*/piwik.$~third-party' }
{ numFalsePositives: 0,
  numExceptionFalsePositives: 0,
  numBloomFilterSaves: 0,
  numExceptionBloomFilterSaves: 0,
  numHashSetSaves: 0,
  numExceptionHashSetSaves: 0 }