Find matching filters should check 3p context

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.

https://www.brave.com

Mozilla Public License 2.0

240 stars 95 forks source link

Find matching filters should check 3p context #167

Closed bbondy closed 5 years ago

bbondy commented 5 years ago

Originally ad-block clients needed to calculate if the context option was 3p or 1p by itself and tell the ad-block lib that. Later we moved that to matches, but we never checked it in find matching filters.

We now automaticlaly calculate it for clients using this function: Fix https://github.com/brave/ad-block/issues/166

pes10k commented 5 years ago

lgtm, and thanks for choosing that as the additional new test :)

bbondy commented 5 years ago

np this was the new test that would fail with the old code btw: https://github.com/brave/ad-block/pull/167/files#diff-e7aab1bb6211409d8b962b4550dc6b09R451