search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

New York Times videos are not playing with ad block turned on #179

Closed erchaves closed 5 years ago

erchaves commented 5 years ago

Steps to reproduce:

I'm not sure if github issues are the proper place to report this, but I hope we can gradually fix these edge cases. Because I want to tell everyone to switch to Brave. But it's hard to tell my friends to switch when they tell me their everyday sites are "broken" in brave just because of tiny edge cases like this one. I do see that other issues were reported for certain videos being blocked and they were addressed, so I'm hoping that it's helpful to report this other specific case. https://github.com/brave/ad-block/issues/119

Thanks!

erchaves commented 5 years ago

P.S. @NYTimes, I've been sending you BAT tips that are waiting for you if you claim your BAT account. Please support BAT and take my monies! Thanks for your continued important work.

bbondy commented 5 years ago

This is fixed as of Brave 0.63.x currently on Beta channel. It will hit release channel around April 23.

erchaves commented 5 years ago

Amazing, thanks so much for your efforts!

On Mon, Apr 15, 2019 at 11:41 PM Brian R. Bondy notifications@github.com wrote:

This is fixed as of Brave 0.63.x currently on Beta channel. It will hit release channel around April 23.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brave/ad-block/issues/179#issuecomment-483499373, or mute the thread https://github.com/notifications/unsubscribe-auth/AASc5d7V0_IeIx0QgXJWnP0EcK419Pv0ks5vhUZmgaJpZM4bFWZe .