search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
240 stars 90 forks source link

Disconnect list is redundant if Google Safe Browsing is enabled #186

Closed fmarier closed 5 years ago

fmarier commented 5 years ago

I looked at the Disconnect simple malware list which we include as part of SafeBrowsingData.dat. It consists of only 53 entries. I tested it manually:

wget https://s3.amazonaws.com/lists.disconnect.me/simple_malware.txt
for u in `tail -n +5 simple_malware.txt` ; do google-chrome --incognito $u ; done

and found that Google Safe Browsing blocked all of the entries except for:

I think we can safely remove it on platforms that have Google Safe Browsing enabled.

bbondy commented 5 years ago

@SergeyZhukovsky are you guys using it?

bbondy commented 5 years ago

Brave-Core doesn't use it Muon used it but is deprecated iOS doesn't have Google Safe Browsing, @jhreis does the new browser use it?

SergeyZhukovsky commented 5 years ago

Android doesn't have Safe Browsing.

bbondy commented 5 years ago

Google Safe Browsing or brave/ad-block Safe Browsing?

SergeyZhukovsky commented 5 years ago

SafeBrowsingData.dat for sure isn't used in Android. I'm not sure how to check about Google's one. We have never made any work related to that. @fmarier could you please check it?

fmarier commented 5 years ago

Here's the current state of Safe Browsing across our supported browsers:

browser Google Safe Browsing SafeBrowsingData.dat
brave-core yes no
browser-android-tabs no no
brave-ios no yes

Test pages for each:

bbondy commented 5 years ago

Thanks @fmarier ! I think @jumde could get Google Safe Browsing working in Android pretty easily using code he did in Brave-core.

jumde commented 5 years ago

There are issues opened in brave-ios and android, assigned the issue to myself:

bbondy commented 5 years ago

Closing this since we emptied the safe browsing lists in #203.