Add -std:c++17 option on Windows to allow [[fallthrough]] attribute

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.

https://www.brave.com

Mozilla Public License 2.0

240 stars 90 forks source link

Closed emerick closed 4 years ago

emerick commented 5 years ago

Fixes #214

emerick commented 5 years ago

@bbondy Could use a review on this one...

emerick commented 4 years ago

Closing this as the Microsoft compiler was updated to address the underlying problem (it should have only ever propduced a warning rather than an error; see https://developercommunity.visualstudio.com/content/problem/315417/error-c2429-on-fallthrough.html).

Just verified that this builds as expected on Windows with Visual Studio Community 2019.