search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
240 stars 90 forks source link

Filter not working #228

Closed ballo closed 4 years ago

ballo commented 4 years ago

This filter doesn't work in Brave (OSX version, if that matters): ebay.com#@#li.s-item:-abp-has(span:-abp-contains(SPONSORED)) Works fine in µBlock Origin for Chromium

pes10k commented 4 years ago

Howdy @ballo

We don't currently ship / support cosmetic filters, though we will soon (no promises but we hope it'll go into nightly shortly). You can follow the issue here https://github.com/brave/brave-browser/issues/5381

Until Brave enables cosmetic filtering, rules like the above definitely won't work. But even when cosmetic filtering goes live, we don't currently support all of the ABP additions to filter rules. We have an issue to support them here https://github.com/brave/adblock-rust/issues/59, though we expect that adding support for the above, procedurally enforced style of rules will be low priority for a while.

Closing this as a dupe of https://github.com/brave/adblock-rust/issues/59. Thanks for the issue!