brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
240 stars 95 forks source link

add MYS to ABPindo #229

Open gmarcher opened 4 years ago

gmarcher commented 4 years ago

ABPindo merupakan filter tambahan untuk melengkapi EasyList memblokir iklan mengganggu di situs berbahasa Indonesia dan Malaysia. form: https://github.com/ABPindo/indonesianadblockrules

ABPindo cover both indonesian and malay region site, so please add MYS code for ABPindo IDN, MYS: ABPindo

pes10k commented 4 years ago

@ryanbr what do you think?

ryanbr commented 4 years ago

Looks pretty clean, a few redundancys from Easylist. https://pastebin.com/EbZjESia but otherwise, looks like a decent list.

pes10k commented 4 years ago

Cool you do the following then?

  1. See how it compares to the list we're using currently (https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt) and see which seems better / its a good idea to switch
  2. If the new list looks better, open any issues with them to remove redundancies and otherwise clena things up
  3. Make a PR against brave/adblock-rust to change the list in the rust code

(if you'd like any help with #3, happy to help there too)

ryanbr commented 4 years ago

@gmarcher possible to remove some dubes in https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt (see: https://pastebin.com/EbZjESia)

gmarcher commented 4 years ago
1. See how it compares to the list we're using currently (https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt) and see which seems better / its a good idea to switch

we are one team/organization https://raw.githubusercontent.com/heradhis/indonesianadblockrules/master/subscriptions/abpindo.txt and https://raw.githubusercontent.com/ABPindo/indonesianadblockrules/master/subscriptions/abpindo.txt (currently main)

gmarcher commented 4 years ago

Looks pretty clean, a few redundancys from Easylist. https://pastebin.com/EbZjESia but otherwise, looks like a decent list.

thanks for your pointer, remove some duplicate done, but not all because we need it.