brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Need block html element in webpage , like ublock origin #230

Closed ghost closed 4 years ago

ghost commented 4 years ago

Brave ad block weakness. not always block ads. So current i using firefox, it has the ublock origin , which really can block all the ads.

See one example ad block rules

cnbeta.com##.cbv810
cnbeta.com##.cbv:not(#cb_share)

it will block an html element which has class name cbv810, and cbv not id equals cb_share

I love brave browser, but due to many ads, i can not using brave as primary browser.

I should using firefox for clean surfing

pes10k commented 4 years ago

Hi @netroby.

Thanks for the issue. A couple of replies 1) this project isn't used any more. Adblocking in brave is now handled by https://github.com/brave/adblock-rust 2) We expect to be shipping cosmetic blocking like you describe very soon, once https://github.com/brave/brave-browser/issues/5381 is merged

pes10k commented 4 years ago

I'm going to close this as a dupe of https://github.com/brave/brave-browser/issues/5381, but if you don't see a fix shipping in dev in the next few weeks, feel free to reopen