search

brave-experiments / ad-block

Ad block engine used in the Brave browser for ABP filter syntax based lists like EasyList.
https://www.brave.com
Mozilla Public License 2.0
239 stars 95 forks source link

Fails to build with Node 14 #235

Open sannysoft opened 4 years ago

sannysoft commented 4 years ago 
note: candidate function not viable: requires single argument 'isolate', but no
      arguments were provided
                Local<String> ToString(Isolate* isolate) const);
                              ^
../ad_block_client_wrap.cc:622:43: error: no matching member function for call to 'ToString'
  String::Utf8Value str(isolate, args[0]->ToString());
pes10k commented 4 years ago

This project is basically unmaintained. Please use Brave's follow up library instead https://www.npmjs.com/package/adblock-rs

Its much more featureful, safer and maintained.