search

brave-intl / bat-client

An example of client code for the BAT.
Mozilla Public License 2.0
7 stars 9 forks source link

Handle BAT-client recovery failure #17

Closed srirambv closed 7 years ago

srirambv commented 7 years ago

Description

Handle BAT-client recovery failure ### Steps to Reproduce
  1. Install/upgrade to 0.19.39
  2. Launch brave from console with LEDGER_VERBOSE=true
  3. Ensure wallet is created
  4. Click advanced setting, recover your wallet
  5. Don't enter any values, click recover, ensure recovery failed message is showed, console logs the error

Actual result:

[ response for GET https://ledger.mercury.basicattentiontoken.org/v2/wallet/941ec251-3187-41fc-b10b-13bd62f6e2df?balance=true&refresh=true&amount=25&altcurrency=BAT ]
>>> HTTP/1.1 503
>>> cache-control: no-cache, no-store
>>> connection: keep-alive
>>> content-length: 506
>>> content-type: text/html; charset=utf-8
>>> date: Wed, 11 Oct 2017 07:33:19 GMT
>>> server: Cowboy
>>>
>>> <!DOCTYPE html>
>>>     <html>
>>>       <head>
>>>             <meta name="viewport" content="width=device-width, initial-scale=1">
>>>             <meta charset="utf-8">
>>>             <title>Application Error</title>
>>>             <style media="screen">
>>>               html,body,iframe {
>>>                     margin: 0;
>>>                     padding: 0;
>>>               }
>>>               html,body {
>>>                     height: 100%;
>>>                     overflow: hidden;
>>>               }
>>>               iframe {
>>>                     width: 100%;
>>>                     height: 100%;
>>>                     border: 0;
>>>               }
>>>             </style>
>>>       </head>
>>>       <body>
>>>             <iframe src="//www.herokucdn.com/error-pages/application-error.html"></iframe>
>>>       </body>
>>>     </html>
+++ busyP=true
<<< GET https://mercury-proxy.privateinternetaccess.com/v2/surveyor/voting/FSgBEh6UD%2Fw3Akir95Fz5h8n5Un6n%2FxudYsegnqkxAF/6a0af783a6240d18354e414b4e7beb9
<<< content-type: application/json; charset=utf-8
<<< accept-encoding:
<<<

Expected result: Should handle the recovery scenario properly Reproduces how often: [What percentage of the time does it reproduce?] 100%

Brave Version

about:brave info:

Brave 0.19.39
rev ebcd280
Muon 4.4.27

Reproducible on current live release:

N/A

Additional Information

cc : @evq @NejcZdovc @mrose17

evq commented 7 years ago

Let's track this here - https://github.com/brave/browser-laptop/issues/11718