search

brave-intl / bat-go

Pass "go", collect 200 BAT
Mozilla Public License 2.0
41 stars 31 forks source link

mock redisconsumer tests rather than spinning up a test redis service #2370

Open kdenhartog opened 6 months ago

kdenhartog commented 6 months ago

These tests look like they were only moved in the nitro-payments-dev branch, but it seems odd that we're spinning up a redis instance to test the /libs/redisconsumer/consumer.go functionality. Could we mock these instead?

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494046922

kdenhartog commented 6 months ago

if we mocked it so that we don't need to include the redis docker image then we would likely address this as well: https://github.com/brave-intl/bat-go/pull/1691#discussion_r1422549125