Operator shares should be bumped to 2 in the calling function

brave-intl / bat-go

Pass "go", collect 200 BAT

Mozilla Public License 2.0

41 stars 31 forks source link

Operator shares should be bumped to 2 in the calling function #2373

Open kdenhartog opened 4 months ago

kdenhartog commented 4 months ago

https://github.com/brave-intl/bat-go/pull/1691#discussion_r1494191389

Alternatively, if we expect this to be globally set we could set this inside the function rather than having the caller pass it in.

Sneagan commented 2 months ago

This check should be removed entirely. Instead, we should be handling the case where the subsequent shamir.Combine call failed due to insufficient or duplicate shares. Add wrapped error or decorator(s) as needed.