brave-intl / bat-go

Pass "go", collect 200 BAT
Mozilla Public License 2.0
41 stars 31 forks source link

feat: change request_id to disallow null and update index #2506

Closed pavelbrm closed 4 months ago

pavelbrm commented 4 months ago

Summary

This PR updates the time_limited_v2_order_creds_unique constraint on the time_limited_v2_order_creds table, thus allowing credentials for multiple unique batches within the same period, which is necessary for Multi Device Refresh.

Type of Change

Tested Environments

Before Requesting Review

Manual Test Plan

pavelbrm commented 4 months ago

lgtm! there is a race that this PR in isolation would expose us to - however the plan as I understand it is to deploy this alongside #2522 where it is fixed

Yes, this and #2522, as well as other related PRs are all planned to go in one release, therefore the risk of the race is minimal if not zero.