PCR reproducibility improvements - Githubissues

brave-intl / bat-go

Pass "go", collect 200 BAT

Mozilla Public License 2.0

41 stars 31 forks source link

PCR reproducibility improvements #2507

Closed evq closed 2 months ago

evq commented 2 months ago

Summary

makefile: new pcrs target combining chained reproducible image build and enclave build
eifbuild: allow for direct enclave build without pulling from image registry
makefile: add cache used during reproducible image builds
eifbuild: split command if passed as a single string
eifbuild: prompt on empty env or command

Type of Change

[ ] Product feature
[ ] Bug fix
[ ] Performance improvement
[ ] Refactor
[x] Other

Tested Environments

[ ] Development
[ ] Staging
[ ] Production

Before Requesting Review

[ ] Does your code build cleanly without any errors or warnings?
[ ] Have you used auto closing keywords?
[ ] Have you added tests for new functionality?
[ ] Have validated query efficiency for new database queries?
[ ] Have documented new functionality in README or in comments?
[ ] Have you squashed all intermediate commits?
[ ] Is there a clear title that explains what the PR does?
[ ] Have you used intuitive function, variable and other naming?
[ ] Have you requested security and/or privacy review if needed
[ ] Have you performed a self review of this PR?

Manual Test Plan