Closed pavelbrm closed 1 month ago
[puLL-Merge] - brave-intl/bat-go@2524
This PR makes various changes to the SKUs service, including:
CreateOrderCreds
and createItemCreds
handler functions to return more specific error responsesDeleteOrderCreds
handler to deleteOrderCreds
and updates it to handle more specific error casesorderItemRepo
dependency to the Service
struct InitService
function to take the new orderItemRepo
dependencygetOrderFull
and getOrderFullTx
helper methods to retrieve an order with its itemsDatastore
methods in favor of using the orderRepo
and orderItemRepo
directlyDeleteOrderCreds
service method to use a transaction and the new getOrderFullTx
helperDeleteLegacy
method to the TLV2
repository for deleting legacy TLV2 order credsdeleteOrderCreds
handler returns more detailed error messages, which could potentially leak sensitive information. The error messages should be reviewed to ensure they do not expose any internal system details.
Summary
This PR builds on #2522, and updates the delete credentials endpoint to only delete TLV2 credentials that have a request id that matches the item id.
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan