brave-intl / bat-go

Pass "go", collect 200 BAT
Mozilla Public License 2.0
41 stars 31 forks source link

fix: Insufficient verification of data authenticity classic builder cache poisoning #2531

Closed imhunterand closed 1 month ago

imhunterand commented 1 month ago

Summary

The project brave-intl/bat-go was used classic builder cache system is prone to cache poisoning if the image is built FROM scratch. Also, changes to some instructions (most important being HEALTHCHECK and ONBUILD) would not cause a cache miss. An attacker with the knowledge of the Dockerfile someone is using could poison their cache by making them pull a specially crafted image that would be considered as a valid cache candidate for some build steps. 23.0+ users are only affected if they explicitly opted out of Buildkit (DOCKER_BUILDKIT=0 environment variable) or are using the /build API endpoint.

Type of Change

Tested Environments

Before Requesting Review

Manual Test Plan

image image

pavelbrm commented 1 month ago

This project does not use the library's code directly. Closing for now. Thanks.