fix: improve and simplify android receipt verification - Githubissues

brave-intl / bat-go

Pass "go", collect 200 BAT

Mozilla Public License 2.0

41 stars 31 forks source link

fix: improve and simplify android receipt verification #2545

Closed pavelbrm closed 1 month ago

pavelbrm commented 1 month ago

Summary

This PR improves receipt verification for Android and cleans it up prior to improving webhooks, as this code will also be used in there.

This PR brings back most of the ideas from #2392 which had been reverted in #2427 (for reasons not related to the code).

Type of Change

[ ] Product feature
[x] Bug fix
[ ] Performance improvement
[x] Refactor
[ ] Other

Tested Environments

[ ] Development
[ ] Staging
[ ] Production

Before Requesting Review

[ ] Does your code build cleanly without any errors or warnings?
[ ] Have you used auto closing keywords?
[x] Have you added tests for new functionality?
[ ] Have validated query efficiency for new database queries?
[ ] Have documented new functionality in README or in comments?
[ ] Have you squashed all intermediate commits?
[x] Is there a clear title that explains what the PR does?
[x] Have you used intuitive function, variable and other naming?
[ ] Have you requested security and/or privacy review if needed
[ ] Have you performed a self review of this PR?

Manual Test Plan