brave-intl / bat-go

Pass "go", collect 200 BAT
Mozilla Public License 2.0
41 stars 31 forks source link

hotWallet in promotion.Service is not used #2547

Closed ibukanov closed 1 month ago

ibukanov commented 1 month ago

The hotWallet field in promotion.Service is not accessed after initialization. So effectively the field is used to validate environment variable values and for nothing else. If such validation makes sense, the code should be refactored just to do the validation. Otherwise it should be removed.