Closed ibukanov closed 1 month ago
I fixed the test failure. It turned out Uphold reports HTTP 401 when connecting using HTTP/2. Previously HTTP/2 was disabled as a custom dialer for fingerprint checks was set on http.Transport
without setting ForceAttemptHTTP2
. But as http.Transport without doing the fingeprint checks was not setting the dialer, that triggered the error in tests. The latest version always disables HTTP/2 explicitly fixing the tests.
The following commits were not verified: 80754bc5ed9e8003a90b31973aca0b1843310aa1 (unsigned) 79e8255a9a8e3e3410b0c1b56f9cac9475572d32 (unsigned)
Summary
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan