Outlook.com Ads not being Blocked even with Brave Shields set to "Aggressive Mode"

DesertBear commented 1 year ago

Description: Ads are not being blocked on outlook.com, even with Brave Shields set to "Aggressive" and "Fanboy Annoyances List" and "uBlock Annoyances List" enabled as well.

They are blocked when the view is set to Roomy, however, they are not blocked when the view is set to Cozy or Compact.

uBlock Origin tries to block them, however still displays a grey box instead of removing it.

Steps to Reproduce: 1) Go to brave://settings/shields and set "Trackers & ads blocking" to "Aggressive".

2) Go to brave://settings/shields/filters and enable "Fanboy Annoyances List" and "uBlock Annoyances List".

3) Sign in to https://outlook.live.com/mail/0/

4) Observe the top of the inbox.

Actual result: Ads are not being blocked.

Screenshot A:

Screenshot B:

Screenshot C:

Screenshot D:

Expected result: The Ads should be blocked and placeholders removed.

Screenshot E:

Screenshot F:

Brave version (brave://version info):

Brave:    1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision: c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS:       Windows 10 Version 22H2 (Build 19045.2728)

antonok-edm commented 1 year ago

@DesertBear with Aggressive mode enabled, it should be fixed in Beta - can you try 1.50.x?

DesertBear commented 1 year ago

For some reason I though the adblock improvements were already added to 1.49 Stable.

In 1.50 Beta, the ad text no longer appears. Although it still shows the grey box, as the EasyList cosmetic filter needs modifying.

antonok-edm commented 1 year ago

For some reason I though the adblock improvements were already added to 1.49 Stable.

:has is supported in 1.49, but I think the specific filter targeting those elements uses -abp-has which is supported in 1.50.

it still shows the grey box, as the EasyList cosmetic filter needs modifying

cc @ryanbr

ryanbr commented 1 year ago

Initial test, not seeing any empty space here. Signed up to some newsletters to try to force some adverts also. (Tested in Brave Beta 1.50.101)

outlook-test

DesertBear commented 1 year ago

@ryanbr

Your screenshots are only showing the view set to "Roomy". Did you try it with "Cozy" and "Compact" as per the original post?

Your second screenshot is also on the Focused tab.

The below screenshots are from Brave Beta 1.50.102, where the issue is still present.

Brave:    1.50.102 Chromium: 111.0.5563.116 (Official Build) beta (64-bit) 
Revision: ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS:       Windows 10 Version 2004 (Build 19041.2728)

1) Right Reading Pane, Focused Inbox Off: Screenshot A