search

brave / adblock-lists

Maintains adblock lists that Brave uses
Mozilla Public License 2.0
319 stars 69 forks source link

Cover goto.walmart.com clean url #1873

Closed ryanbr closed 1 week ago

ryanbr commented 1 week ago

https://goto.walmart.com/c/159047/565706/9383?&sharedid=cnet&partnerpropertyid=235399&u=https%3A%2F%2Fwww.walmart.com%2Fip%2FApple-Lightning-to-3-5-mm-Headphone-Jack-Adapter%2F54738078%3F&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo

https://goto.walmart.com/c/159047/565706/9383?&sharedid=cnet&partnerpropertyid=235399&u=https%3A%2F%2Fwww.walmart.com%2Fip%2FApple-Lightning-to-3-5-mm-Headphone-Jack-Adapter%2F54738078%3F&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo

->

https://goto.walmart.com/c/159047/565706/9383?&u=https%3A%2F%2Fwww.walmart.com%2Fip%2FApple-Lightning-to-3-5-mm-Headphone-Jack-Adapter%2F54738078%3F&subId1=cn-bbdb4f53b6d64a02b50d53c6343ce6a2-dtp-oo
fmarier commented 1 week ago

Hm, this one is supposed to get debounced already which would remove all of the params.

It looks like something is broken in the copy clean link implementation. Let's follow up in https://github.com/brave/brave-browser/issues/39618. Fixing that bug will remove all of these params automatically.