search

brave / adblock-lists

Maintains adblock lists that Brave uses
Mozilla Public License 2.0
336 stars 74 forks source link

Remove suspicious exception rules from EP #38

Open pes10k opened 5 years ago

pes10k commented 5 years ago

There are many exception rules in EP that are suspicious, and allow google analytics, google tag manager, and similar through for unclear reasons:

ex:

@@||portalbici.es/lib/angulartics-google-analytics/dist/angulartics-ga.min.js
@@||google-analytics.com/analytics.js$domain=tradera.com|xxl.se
@@||google-analytics.com/plugins/ua/ec.js$domain=xxl.se
@@||googletagmanager.com/gtm.js?id=$domain=tradera.com|xxl.se

We should not respect these cases. We could do this most easily by removing the exception rules in these cases.

@bbondy if the above sounds like an attractive idea, I can work with @lukemulks to come up with some rules to filter these out (meta-filter rules? :P)

bbondy commented 5 years ago

the only thing I can think of is if they are done for webcompat reasons. In which cases it's still preferable to give a mock response instead. Yes please go ahead.
As with other changes, I'd want this applied via some kind of exclude filter list when parsing.

pes10k commented 5 years ago

Is there "exclude" filter list in place now to add to, or would it be better to add another step to ingesting in https://github.com/brave/adblock ?

bbondy commented 5 years ago

I don't think so but I think we filter some rules from scripts/generateDataFiles.js

pes10k commented 5 years ago

Okie dokie. I'll talk with @lukemulks about coming up with some sane initial filter-filters. I'll track the list here, and add the functionality into brave/adblock