brave / adblock-lists

Maintains adblock lists that Brave uses
Mozilla Public License 2.0
331 stars 71 forks source link

Incorrectly hidden elements on page #431

Closed ghost closed 4 years ago

ghost commented 4 years ago

https://www.soulreaperzone.com/anime/re-zero-starting-life-in-another-world-season-2/

When the adblocker is enabled the website hides the download buttons. Please fix it

pes10k commented 4 years ago

@Bluedot221 thank you for the bug report!

@antonok-edm the download buttons show in ublock origin. Once you switch things over to those lists this week, can you either i) test and see if the download buttons appear in Brave, or ii) ping me and I can test the same?

ghost commented 4 years ago

I reported it to the uBO maintainers and also to Adguard list maintainers and also to Nano adblocker developers. They fixed it. The download buttons appear when using uBO but not on Brave browser. I'm on Android with Brave browser version Version 1.10.99. I cannot install uBO on Brave browser on Android yet.


I have a lot of websites that are using anti-adblock. Should I list them here? Do I need to create seperate issues for each website or should I dump them all at once in a single issue?

Thanks a lot for helping.

pes10k commented 4 years ago

I have a lot of websites that are using anti-adblock. Should I list them here? Do I need to create separate issues for each website or should I dump them all at once in a single issue?

If you have a list of these, of sites showing anti-adblock messages that Brave doesn't hide, then that would be really great to know, thanks! No need to go to the trouble of creating a new issue for each of them, that sounds tedious. But if you could create just one issue and list them there, we can take it from there (whether that means breaking the issues out on our side, or some other place for storing them).

@Bluedot221 thank you again for this help!

ryanbr commented 4 years ago

I just tested this site (Shields, aggressive), I get 2 download button links: @Bluedot221

download

ryanbr commented 4 years ago

related report: https://github.com/NanoMeow/QuickReports/issues/2642 (From Jan 6th/2020)

ghost commented 4 years ago

If it's not much to ask. Can you please try to download and follow the sites this website redirects to. It seems they are using link shorteners and redirects through a lot of websites before reaching the final destination. And in between you'll find a lot of unblocked ads and Anti adblockes too and pop-up new tabs as well.

Furthermore if you try to download again from the first step it'll take to other link shorteners each time.


How can this force the the 'Aggressive' mode on Android?

In uBO, with annoyances enabled from Fanboys list and uBO. The website doesn't feature these many ads, anti-adblocks, and redirects and pop-ups.

ryanbr commented 4 years ago

@Bluedot221 Android-side of things regarding cosmetic/snippets is still work in progress, just no ETA just yet. We're currently in progress developing more filter options in future Brave releases, making more insync with the default uBO filters.

I've look at few sample links from soulreaperzone (tested on Brave Desktop Release), both links seem to work well.

https://sznlink.xyz/honzuki-no-gekokujou-2nd-season-12-end-erai-raws-multisubs-9012/ https://tmearn.com/TEYeMO2

ghost commented 4 years ago

Okay, thanks for looking into it, can you also have a look at these please:

https://sznlink.xyz/hanamonogatari-bluray-mega-99616/ -- Anti adblock

https://tii.ai/J1ITSV4u -- pop ups new tabs while solving captchas and after clicking 'Get link' button.

https://ouo.press/Fxsn1v -- click on 'I'm a human' and see an unblocked ad below the 'Get link'

ryanbr commented 4 years ago

Tested in Brave Desktop Release, didn't see any Anti-adblock warnings. I would test with uBO disabled, and default shields enabled. I did notice having uBo enabled with shields enabled caused some warnings to show.

I have implement a further patch to fix some revolving adservers which will help all platforms (ios/desktop/android).

ghost commented 4 years ago

Will these patches update automatically or will they come with Brave browser updates?

ryanbr commented 4 years ago

These patches will be seen in the next 24-48hrs. and for ouo.press https://github.com/easylist/easylist/commit/790c18b

Won't completely eliminate the popups, but it should help a little.

ryanbr commented 4 years ago

I'll check after the weekend, if everything looks good on this website I'll update/close this ticket. Thanks for help and feedback @Bluedot221

ghost commented 4 years ago

@ryanbr sorry for pinging you.

I'm seeing ads on https://animekaizoku.com/. I don't see them on desktop but on Android they do. Can nothing be done about them? It's the only reason I'm forced to use other browsers and switching default browser everytime is tedious.

ryanbr commented 4 years ago

They're using revolving adservers, various random domains. Have added servers from them today/yesterday. Most of these changes will get to Ios and android. Ios adblock updates have been temporarily delayed (give it a few days or so).

Brave IOS may not be ideal for this site, given how many domain changes happening regularly to counter Easylist. Brave desktop has better options (snippets) to counter this.

ghost commented 4 years ago

I was not taking about the https://www.soulreaperzone.com this site has its own problems, I don't expect much from this site.

This is another site that I'm taking about: https://animekaizoku.com/

ryanbr commented 4 years ago

Okay, will look into it.

ghost commented 4 years ago

Sorry, brave browser's Shields were off at that time when I visited https://animekaizoku.com/. Ads don't appear when Shields are on on this site. sorry again for interrupting you.

ryanbr commented 4 years ago

Closing ticket, both sites are working well. tag me if there is more issues @ghost

ghost commented 4 years ago

@ryanbr anti-adblock here: https://sznlink.xyz/re-zero-kara-hajimeru-isekai-seikatsu-2nd-season-06-multisubs-hevc-7464.

Other than this everything seems to work fine.

Brave browser on Android: Version 1.12.113

Screenshot_20200814_113413

ryanbr commented 4 years ago

Android circumvention is limited, no easy fix for this site. Just disable site trackers for this site. just too many items to whitelist.

ghost commented 4 years ago

Okay, I just disabled Block cross-site trackers and the anti-adblock message is gone and there are no ads appearing as well. Thanks.