brave / adblock-rust

Brave's Rust-based adblock engine
Mozilla Public License 2.0
1.46k stars 124 forks source link

Support other procedural filters #293

Open ryanbr opened 1 year ago

ryanbr commented 1 year ago

Coming from the post; https://www.reddit.com/r/brave_browser/comments/13lnfky/does_brave_now_fully_support_procedural_filtering/

https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters

Currently supporting :has

As of 19/05/2023, Popularity of filters in uBO:

Filter Number of filters used
has-text 494
upward 352
xpath 49
matches-css 48
matches-path 7
matches-media 3
matches-attr 2
watch-attr 1
laymonage commented 1 year ago

Just noticed that Brave doesn't support has-text. Would be awesome to have that feature!

superlex commented 1 year ago

AdGuard lists use :contains() instead of :has-text(), Brave should support both of them.

chris-fj commented 8 months ago

Bumping this issue. It would be great to start supporting these selectors

Yuki2718 commented 6 months ago

Any news on this? Facebook ads (video pages or on mobile) are unblocked by the lack of has-text().

CapSel commented 2 months ago

In the mean time one can use "Stylebot" to match and hide elements using CSS matching.

chris-fj commented 2 months ago

Thanks for the suggestion. However, I’m wondering what can StyleBot do that uBlock can’t, because having to install an extension kind of defeats the purpose of having a built-in adblocker. Specially for my use case, where I wanted to do the blocking on an iPhone on which I can’t install any extensions.

On Aug 23, 2024 at 11:38 PM, <CapSel @.***)> wrote:

In the mean time one can use "Stylebot" to match and hide elements using CSS matching.

— Reply to this email directly, view it on GitHub (https://github.com/brave/adblock-rust/issues/293#issuecomment-2307842942), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ABQMROUBAKLOCZDMN7KN7ADZS6TTXAVCNFSM6AAAAAAYHTBWTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHA2DEOJUGI). You are receiving this because you commented.Message ID: @.***>