Closed IanKrieger closed 6 months ago
[puLL-Merge] - brave/ads-ui@1137
This pull request makes adjustments to the localization files and other components to ensure consistency in the naming and organization of various features across different localizations. The primary change involves the correction of the term "AdSets" to "Ad Sets" in the SearchCampaignReportView.tsx
file to maintain coherence with other parts of the codebase.
en.js
, es.js
and pt.js
): While not generally a security concern, the deletion of entire locale files if unintended could impact the functionality related to internationalization. Ensure deletions were intentional and corresponding .po
files or alternatives are in place to manage localization.SearchCampaignReportView.tsx
: The change made is primarily cosmetic and does not directly impact security. However, as with any modification to UI components, ensure this change doesn't inadvertently affect the display of important information or controls related to security features (like permission settings or display of user data).But how do I test this? I'd like to see an easy way to bring up the dashboard in spanish so I can review what English test is still showing.
I changed brave beta browser's primary language to be in spanish, as seen in the screenshot I added. Will have to deploy to make sure behaviour is the same,
Also, as we change the english strings later, what breaks / reports to give us feedback that we now need additional strings translated?
That should be handled when you run npm run extract
any changes to text are matched against an exact id which in this case is basically the text. if that id doesn't exist, it says a translation is missing.
But how do I test this? I'd like to see an easy way to bring up the dashboard in spanish so I can review what English test is still showing.
I changed brave beta browser's primary language to be in spanish, as seen in the screenshot I added. Will have to deploy to make sure behaviour is the same,
OK! In a future PR I'd like us to make trying different locales easier (perhaps also including the pseudolocale) for testing. Either by 1) supporting a locale=en-US
query parameter on application load to force the locale detection or 2) (less preferred) a dev time env var e.g. OVERRIDE_LOCALE=en-US npm start
or 3) (even less preferred) writing up in the readme how to switch locales in the brave. But not as part of this PR.
I didn't see the screenshot when I first wrote the comment ;)
Also, as we change the english strings later, what breaks / reports to give us feedback that we now need additional strings translated?
That should be handled when you run
npm run extract
any changes to text are matched against an exact id which in this case is basically the text. if that id doesn't exist, it says a translation is missing.
Ahh, yes, that makes sense. I think in due course we'll lose track, and I'd like a build-time check / report if possible - especially if the values have changed - but again let's hold off on that for now.
Spanish translation for: https://github.com/brave/roadmap/issues/1115