search

brave / ads-ui

Self-service ads UI
Mozilla Public License 2.0
23 stars 11 forks source link

Production Release 2024-03-19 #1140

Closed IanKrieger closed 6 months ago

IanKrieger commented 6 months ago

Features

Fixes

Chores

github-actions[bot] commented 6 months ago

[puLL-Merge] - brave/ads-ui@1140

Description

This pull request introduces changes across several files including package.json, various components, and locale files. The main changes seem to involve dependency updates, UI adjustments, and localization efforts.

Changes ### Changes #### `package.json` - Bumped versions for `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` from `6.21.0` to `7.2.0`. #### `src/components/Button/AlwaysOnFormButton.tsx` - Adjusted the `left` CSS property of a button from `90%` to `85%`. #### `src/components/Route/RouteSelectionButton.tsx` - Added a `margin` property. #### Localization Files (`src/locales/en.js`, `src/locales/es.js`, `src/locales/pt.js`) - The Portuguese (`pt.js`) and Spanish (`es.js`) localization files were deleted. - Updates were made in `src/locales/en.po` and `src/locales/pt.po` to reflect changes in strings, possibly due to UI modifications or feature updates. - `src/locales/en.po` reflects additions and updates to various user-facing messages. #### `src/user/views/user/reports/SearchCampaignReportView.tsx` - Changed "AdSets" to "Ad Sets" for consistency with other UI elements or possibly as a correction.

Security Hotspots

  1. Localization Deletions: The removal of pt.js and es.js could impact users who rely on these locales. While not a direct security concern, it may affect user experience and accessibility.

  2. Dependency Updates (package.json): Updating dependencies can introduce breaking changes or new vulnerabilities if not properly vetted. In this case, updating the eslint plugins should generally be safe, but it's worth ensuring that these new versions don't introduce compatibility issues or depend on packages with known vulnerabilities.

  3. UI Changes (AlwaysOnFormButton.tsx and RouteSelectionButton.tsx): Any time UI changes are made, especially those involving positioning or margins, it's important to verify that they do not inadvertently make elements unusable or inaccessible, particularly for users relying on assistive technologies.