Closed tackley closed 4 months ago
[puLL-Merge] - brave/ads-ui@1181
This PR makes changes to the user interface for the search advertising setup flow. It adds new components and sections for reviewing the advertiser profile, selected ads, landing page details, and query parameters. The motivation seems to be to provide a more guided and detailed setup process for advertisers creating search campaigns.
Appending arbitrary query parameters to advertiser landing page URLs could potentially be abused if not properly validated and sanitized. The values should be strictly checked to prevent injection of malicious scripts or URLs.
The notes field where advertisers can enter free text to send to the account manager should have its contents sanitized and scanned for potential spam or abusive language before storing and displaying to the recipient.
Any new form inputs added, like the landing page URL, should have strict validation and error handling to prevent malformed data from being submitted.
Apparently if you don't do this you get junk displayed after deployment. Going forward we need to make this less error-prone. But for now just run
npm run extract
.Also fix a typo that I noticed while reviewing.