Closed tackley closed 4 months ago
[puLL-Merge] - brave/ads-ui@1182
This PR adds the favicon
field to the SearchLandingPageWithStats
fragment and uses it in the SearchPreview
component. It allows displaying the favicon associated with a landing page in the search campaign creation UI.
favicon
URL is validated and filtered before rendering. Risk: MediumLet me know if you have any other questions!
- Displaying user-supplied favicons could potentially be an XSS vector if not properly sanitized. Ensure the
favicon
URL is validated and filtered before rendering. Risk: Medium- Fetching favicons from arbitrary origins may expose user activity if not proxied through a secure server. Consider proxying the favicon requests. Risk: Low
We deliberately use the same image proxy server as search does to display these icons.
Relies on https://github.com/brave/ads-serve/pull/3884