brave / ads-ui

Self-service ads UI
Mozilla Public License 2.0
22 stars 11 forks source link

feat: remove registration choice, add search page #1199

Closed IanKrieger closed 3 months ago

IanKrieger commented 3 months ago

Add a more verbose distinction as to what users are signing up for when it comes to search.


https://github.com/brave/ads-ui/assets/48930920/a5e8c228-1fbc-448f-9b9f-86b5656b222b

github-actions[bot] commented 3 months ago

[puLL-Merge] - brave/ads-ui@1199

Description

This PR adds a new Search Landing Page to the Brave Ads UI. It includes information about Brave Search Ads, a button to determine eligibility, and an image carousel showcasing search results. The landing page aims to tap into the large volume of annual web searches and promote Brave Search Ads to potential advertisers.

Changes ### Changes - `src/App.tsx` - Added import and route for the new `SearchLandingPage` component - Changed the `/search` route to render `SearchLandingPage` instead of redirecting to "/contact" - `src/auth/registration/` - Removed the `AccountChoice.tsx` file which contained the UI for choosing between browser ads and search ads - Updated `Register.tsx` to remove the `AccountChoice` route and directly redirect to "register/browser" - `src/basic-attention-token/BasicAttentionTokenLandingPage.tsx` - Updated the "Get started" button link to just "/register" instead of "/register?pos=personal" - `src/components/AppBar/LandingPageAppBar.tsx` - Added "Brave Search" link to header - Refactored to use a mobile menu for links on small screens - Minor style and sizing tweaks - `src/search/SearchLandingPage.tsx` *(new)* - New component that renders the Search landing page - Includes headlines, description, CTA button, and image carousel - Uses `SearchTalkingPoints` component to render key selling points - `src/search/SearchTalkingPoints.tsx` *(new)* - New component that renders the key value propositions of Brave Search Ads - Promotes Search Ads as incremental reach, as effective as Google, and risk-free to test

Security Hotspots

None identified. The changes are primarily adding new UI components and routes without handling any sensitive user data or system operations that could introduce vulnerabilities.