brave / ads-ui

Self-service ads UI
Mozilla Public License 2.0
24 stars 11 forks source link

fix: update logo for product consistency #1211

Closed IanKrieger closed 4 months ago

IanKrieger commented 4 months ago

Want to change the logo for more consistency


https://github.com/brave/ads-ui/assets/48930920/8426a90d-dccb-410f-a726-6c821ceaead7

lukaslevert commented 4 months ago

Logo, headers, and hamburger menu look great @IanKrieger.

What about if we changed "Ad inquires" to "Contact sales" so that it's clear that it's not just general inquiries, but a way of contacting the sales team?

What I'd like to try to avoid is people contacting that email with support queries for self-service, since those should be going to the ad ops email, not the sales outreach.

github-actions[bot] commented 4 months ago

[puLL-Merge] - brave/ads-ui@1211

Description

This PR makes several changes to the landing page UI, including:

The motivation seems to be to improve the landing page navigation and branding.

Changes ### Changes **src/assets/images/full-brave-brand-black.svg** and **src/assets/images/full-brave-brand.svg** - Added new SVG versions of the Brave logo **src/components/AppBar/LandingPageAppBar.tsx** - Imported the new Brave logo SVGs and use them conditionally based on page - Added several new `PageLink` components to the app bar for pages like "Brave Search Ads", "Basic Attention Token" etc - Moved "Get started" link into a `PageLink` - Added the page links to the mobile menu - Some other minor refactoring and cleanup **src/components/AppBar/PageLink.tsx** - Added new reusable `PageLink` component that renders a link with translated text - Takes `to` prop for URL, `msg` prop for i18n message, and `textColor` - Handles mobile styling **src/locales/en.po**, **src/locales/es.po**, **src/locales/pt.po**, **src/locales/test.po** - Localization file updates **src/search/SearchLandingPage.tsx** - Minor padding tweak to image carousel on small screens

Security Hotspots

Let me know if you have any other questions!