search

brave / ads-ui

Self-service ads UI
Mozilla Public License 2.0
24 stars 11 forks source link

Production Release 2024-06-13 #1231

Closed IanKrieger closed 3 months ago

IanKrieger commented 3 months ago

Features

Fixes

Chores

github-actions[bot] commented 3 months ago

[puLL-Merge] - brave/ads-ui@1231

Description

This PR updates several dependencies in the package.json file, including @mui/x-data-grid, @mui/x-date-pickers, @types/lodash, knip, prettier, typescript-eslint, and vite. It also updates the CodeQL GitHub Actions workflow to use the latest version (v3.25.8).

Additionally, the PR makes some code changes:

Changes ### Changes `.github/workflows/codeql-analysis.yml` - Updates CodeQL Actions to v3.25.8 `eslint.config.js` - Adds `getGenericMultiSelect` to list of allowed global identifiers `package.json` - Updates several dependencies to newer versions `src/auth/components/AdvertiserDetailsForm.tsx` - Defines new GraphQL mutation `Advertiser_Update` - Updates form submission to use `Advertiser_Update` mutation `src/components/Date/DateRangePicker.tsx` - Adjusts selected `from` and `to` dates to start/end of day in UTC timezone `src/graphql-client/gql.ts` and `src/graphql-client/graphql.ts` - Regenerated GraphQL types and documents `src/graphql/ads-serve.graphql.schema.json` - Updated GraphQL schema `src/routes/campaigns/analytics/*` - Various changes to analytics components, hooks, filters, graphs, and metrics - Removes some search-specific components - Updates breakdown and filter handling - Localizes some strings `src/user/settings/NewKeyPairModal.tsx` - Updates to use `Advertiser_Update` mutation `src/user/views/user/CampaignReportViewSelector.tsx` - Removes `SearchCampaignReportView` `src/user/views/user/reports/SearchCampaignReportView.tsx` - File removed

Possible Issues

The PR makes a lot of changes to the campaign analytics functionality. While the changes seem reasonable, thorough testing should be done to ensure the analytics pages still function as expected after these updates. Backwards compatibility with saved analytics links and any APIs consuming this data should also be verified.

The removal of the search-specific analytics components suggests the UI/UX for search campaign analytics may have changed. The new experience should be validated with users.