search

brave / ads-ui

Self-service ads UI
Mozilla Public License 2.0
23 stars 11 forks source link

Production Release 2024-08-06 #1300

Closed IanKrieger closed 1 month ago

IanKrieger commented 1 month ago

Features

Fixes

github-actions[bot] commented 1 month ago

[puLL-Merge] - brave/ads-ui@1300

Description

This PR makes significant changes to the Brave Search Ads landing page, registration process, and campaign management functionality. It updates the UI, improves user experience, and refines the campaign validation logic.

Changes ### Changes 1. `src/assets/videos/setting_up_brave_search_ads.mp4`: - Added a new video asset for setting up Brave Search Ads. 2. `src/auth/registration/Register.tsx`: - Removed the `SearchRegister` component. - Added a redirect from "/register/search" to "/search". 3. `src/auth/registration/SearchForm.tsx`: - Modified the width of the form to a fixed 375px. 4. `src/auth/registration/SearchRegister.tsx`: - Redesigned the registration form with a new layout and styling. - Added a video preview and updated the content. 5. `src/basic-attention-token/PrivacyPolicy.tsx`: - Updated the typography variant for search-specific privacy policy. 6. `src/components/Campaigns/CampaignDateRange.tsx`: - Added a warning message when the campaign might end prematurely due to budget constraints. 7. `src/locales/*.po`: - Updated translations for various languages. 8. `src/search/SearchLandingPage.tsx`: - Completely redesigned the Search landing page with new content, layout, and video integration. 9. `src/search/SearchTalkingPoints.tsx`: - Updated the talking points with new content and styling. 10. `src/user/library/index.ts`, `src/user/views/adsManager/types/index.ts`, `src/validation/CampaignSchema.tsx`: - Removed the `validateStart` field from campaign forms and validation. 11. `src/util/campaign.ts`: - Added a new function `isFuzzyCalculatedDailyBudgetOk` to check if the campaign budget is sufficient for the given date range. 12. `src/validation/CampaignSchema.tsx`: - Updated the campaign validation schema to use the new `isFuzzyCalculatedDailyBudgetOk` function. - Modified the start date validation to only apply for new campaigns.

Possible Issues

  1. The fixed width of 375px for the SearchForm might not be responsive on all device sizes.
  2. The removal of the validateStart field might affect existing campaigns or integrations that rely on this field.

Security Hotspots

No significant security hotspots were identified in this PR.