search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.92k stars 2.35k forks source link

[Android] Fix chromium 84 warnings #10327

Closed NejcZdovc closed 1 year ago

NejcZdovc commented 4 years ago 
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:336 Avoid using sizes smaller than `12sp`: `10sp`: SmallSp [warning]
                    android:textSize="10sp" />
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:371 Avoid using sizes smaller than `12sp`: `10sp`: SmallSp [warning]
                    android:textSize="10sp" />
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:405 Avoid using sizes smaller than `12sp`: `10sp`: SmallSp [warning]
                    android:textSize="10sp" />
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout/brave_toolbar.xml:85 Avoid using sizes smaller than `12sp`: `9sp`: SmallSp [warning]
          android:textSize="9sp" />
          ~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:28 Missing `contentDescription` attribute on image: ContentDescription [warning]
            <ImageView
             ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:58 Missing `contentDescription` attribute on image: ContentDescription [warning]
                        <ImageView
                         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:66 Missing `contentDescription` attribute on image: ContentDescription [warning]
                        <ImageView
                         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:74 Missing `contentDescription` attribute on image: ContentDescription [warning]
                        <ImageView
                         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:95 Missing `contentDescription` attribute on image: ContentDescription [warning]
                        <ImageView
                         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:218 Missing `contentDescription` attribute on image: ContentDescription [warning]
        <ImageView
         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:462 Missing `contentDescription` attribute on image: ContentDescription [warning]
                    <ImageView
                     ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:496 Missing `contentDescription` attribute on image: ContentDescription [warning]
                    <ImageView
                     ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout/new_tab_page_layout.xml:17 Missing `contentDescription` attribute on image: ContentDescription [warning]
    <ImageView
     ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout/user_wallet_activity.xml:74 Missing `contentDescription` attribute on image: ContentDescription [warning]
        <ImageView
         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout/user_wallet_activity.xml:90 Missing `contentDescription` attribute on image: ContentDescription [warning]
        <ImageView
         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout/user_wallet_activity.xml:109 Missing `contentDescription` attribute on image: ContentDescription [warning]
        <ImageView
         ~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:285 Hardcoded string "0.00 BAT", should use `@string` resource: HardcodedText [warning]
                    android:text="0.00 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:320 Hardcoded string "1 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOff="1 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:321 Hardcoded string "1 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOn="1 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:335 Hardcoded string "0.00 USD", should use `@string` resource: HardcodedText [warning]
                    android:text="0.00 USD"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:355 Hardcoded string "5 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOff="5 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:356 Hardcoded string "5 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOn="5 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:370 Hardcoded string "0.00 USD", should use `@string` resource: HardcodedText [warning]
                    android:text="0.00 USD"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:389 Hardcoded string "10 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOff="10 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:390 Hardcoded string "10 BAT", should use `@string` resource: HardcodedText [warning]
                    android:textOn="10 BAT"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:404 Hardcoded string "0.00 USD", should use `@string` resource: HardcodedText [warning]
                    android:text="0.00 USD"
                    ~~~~~~~~~~~~~~~~~~~~~~~
../../../home/brave/brave-browser/src/chrome/android/java/res/layout-land/brave_rewards_site_banner.xml:418 `@id/make_monthly_text` can overlap `@id/make_monthly_checkbox` if @string/brave_ui_make_monthly grows due to localized text expansion: RelativeOverlap [warning]
                <TextView
NejcZdovc commented 4 years ago

@mkarolin is this fixed with your 84 PR?

mkarolin commented 4 years ago

@samartnik may have the answer.

samartnik commented 4 years ago

These are long-standing warnings not related to cr84. They will be addressed separately.

NejcZdovc commented 4 years ago

👍

bsclifton commented 3 years ago

@deeppandya did you recently fix these?

deeppandya commented 3 years ago

@bsclifton yes it fixed most of it. And remaining ones would be addressed soon.