[Desktop] JS errors in the console when opening a Private Window

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.73k stars 2.31k forks source link

[Desktop] JS errors in the console when opening a Private Window #10447

Open fmarier opened 4 years ago

fmarier commented 4 years ago

Description

There are unchecked runtime errors in the newtab page of private windows.

https://github.com/brave/brave-browser/issues/1194 is similar but for Tor Windows.

Steps to Reproduce

Open a new Private Window
Open the devtools console

Actual result:

Screenshot from 2020-06-24 11-54-50

Expected result:

No errors.

Reproduces how often:

Always

Brave version (brave://version info)

Brave   1.11.69 Chromium: 83.0.4103.106 (Official Build) beta (64-bit)
Revision    ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS  Linux

dentistformyeye commented 3 years ago

When I turn off Rewards, only this shows up in the private newtab console.

Here's the result if I turn on rewards and open another private newtab (or return to an existing private newtab). I haven't been using Rewards; I don't know if that affects anything. The "Rewards service is not initialized" error repeats about once every 30 seconds. That "Unknown error" doesn't appear for me, so an update might have fixed it.

Brave	1.18.70 Chromium: 87.0.4280.101 (Official Build) (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H2)