Open jumde opened 4 years ago
Problematic includes
# "//brave/components/brave_wallet/common:mojom__generator", non visible
# "//brave/browser/ethereum_remote_client:browser", circular deps
# "//brave/browser/ui", circular deps
chrome/browser/build.gn
allow_circular_includes_from += [
"//chrome/browser/apps/platform_apps",
# TODO(https://crbug.com/883570): This is unfortunate, but not easy to
# fix. Ideally, //chrome/browser:browser shouldn't depend on these APIs
#(though the APIs likely will depend on //chrome/browser), but we need
# to pull them in here to allow registration of keyed services.
"//chrome/browser/apps/platform_apps/api",
"//chrome/browser/extensions",
# TODO(crbug.com/1200215): Remove cycles and simplify all dependencies.
"//chrome/browser/web_applications/extensions",
]
deps += [
chrome is allowing extension to have circular deps