[Desktop] Remove chrome://new-tab-page

fmarier commented 4 years ago

Description

Open chrome://new-tab-page triggers requests to Google servers which don't go through our proxy.

chrome-untrusted://new-tab-page/custom_background_image?url=https%3A%2F%2Flh4.googleusercontent.com%2Fproxy%2FkF...

Steps to Reproduce

Run a local intercepting proxy like mitmproxy: mitmproxy --socks --port 9000
Start Brave in proxy mode: brave-browser-nightly --proxy-server="socks5://localhost:9000"
Open chrome://new-tab-page

Actual result:

The following requests to Google servers are triggered:

https://www.google.com/async/newtab_ogb?hl=en-GB&async=fixed:0
https://www.google.com/async/ddljson?async=ntp:2
https://www.google.com/async/newtab_promos
https://fonts.googleapis.com/css?lang=en-GB&family=Product+Sans|Roboto:400,700
https://www.gstatic.com/og/_/ss/k=og.qtm.1kpmk2jdrun5m.L.W.O/m=qmd,qcwid/excm=qaaw,qabr,qadd,qaid,qalo,qebr,qein,qhaw,qhbr,qhch,qhga,qhid,qhin,qhlo,qhmn,qhpc,qhpr,qhsf,qhtb,qhtt/d=1/ed=1/ct=zgms/rs=AA2YrTvftdZCTQFhW1kDfl4AMFB...
https://www.gstatic.com/images/branding/googlelogo/svg/googlelogo_clr_74x24px.svg
https://www.gstatic.com/og/_/js/k=og.qtm.en_US.SvsPckT-cMA.O/rt=j/m=q_d,qmd,qcwid,qmutsd,qapid,qald/exm=qaaw,qabr,qadd,qaid,qalo,qebr,qein,qhaw,qhbr,qhch,qhga,qhid,qhin,qhlo,qhmn,qhpc,qhpr,qhsf,qhtb,qhtt/d=1/ed=1/rs=AA2YrTuLA...
https://ogs.google.com/widget/app/so?gm2&origin=chrome%3A%2F%2Fnew-tab-page&pid=1&spid=243&hl=en-GB&gm=

Expected result:

These should be proxied.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave   1.12.79 Chromium: 84.0.4147.68 (Official Build) nightly (64-bit)
Revision    e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS  Linux

fmarier commented 4 years ago

An alternative to proxying these request would be to remove this page from Brave entirely.

petemill commented 4 years ago

Yes we should just not serve anything from this domain

rebron commented 3 years ago

Let's go ahead and remove chrome://new-tab-page entirely.

fmarier commented 3 years ago

Not sure when it was done, but that page is gone now.

rebron commented 3 years ago

Page is still up. I think there was a typo chrome://new-tag-page vs chrome://new-tab-page

bsclifton commented 8 months ago

There is now a crash that happens when you click the search box on brave://new-tab-page - see https://github.com/brave/brave-browser/issues/36393

I agree that we should consider removing this page. There are folks using it though - we'll want to account for that if we do decide to remove it.

I'll add this to Desktop papercuts

simonhong commented 8 months ago

@bsclifton How about redirect brave://new-tab-page to brave://newtab? It would be simplest fix.

bsclifton commented 8 months ago

@simonhong that works for me... @rebron WDYT?

rebron commented 8 months ago

@bsclifton @simonhong The redirect makes sense to me.

bsclifton commented 3 months ago

Needs some more thought before we start work. It might be good to change the behavior to proxy instead of removing this page. There are folks using this page actively - a few users have commented they will stop using Brave if this is removed. We could also potentially remove the Google logo and put our branding there too

brave / brave-browser