Disable Widevine in Tor mode

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.85k stars 2.33k forks source link

Disable Widevine in Tor mode #1076

Open bsclifton opened 6 years ago

bsclifton commented 6 years ago

Carried over from https://github.com/brave/browser-laptop/issues/13626

kjozwiak commented 5 years ago

Still an issue, easiest way to reproduce, see the issue occurring:

visit https://bitmovin.com/demos/drm

You'll notice that you'll get a Widevine notification and can install it inside a Tor Window. Example:

installingwidevinetor

iefremov commented 5 years ago

Blocking the Widevine installation prompt is trivial, we have just to add a check for Tor profile in BraveDrmTabHelper::OnWidevineKeySystemAccessRequest. Do we also have to block playing Widevine videos in Tor windows if Widevine is already installed? @diracdeltas @bsclifton

diracdeltas commented 5 years ago

i think we should not allow widevine in tor mode even if already installed (same with flash if its installed) but defer to @tomlowenthal

tildelowengrimm commented 5 years ago

I agree with @diracdeltas on this one. My preference is to disable Widevine entirely in Tor: no prompt to install, and no playing if it's already installed.

iefremov commented 5 years ago

No playing goal should be achievable by disabling the content setting for plugins.