kjozwiak
commented
4 years ago Moving out of the 1.13.x milestone after talking with @ryanml. Approach was rethought regarding the above hence not making it into 1.13.x.
Open ryanml opened 4 years ago
kjozwiak
commented
4 years ago Moving out of the 1.13.x milestone after talking with @ryanml. Approach was rethought regarding the above hence not making it into 1.13.x.
The protocol handlers to handle the oauth redirect for Gemini, Rewards, and Binance are very similar, and should be merged. This handler should be extensible for future integrations.
https://github.com/brave/brave-core/blob/master/browser/gemini/gemini_protocol_handler.cc https://github.com/brave/brave-core/blob/master/browser/binance/binance_protocol_handler.cc https://github.com/brave/brave-core/blob/master/components/brave_rewards/browser/rewards_protocol_handler.cc