brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.89k stars 2.34k forks source link

[Desktop] Crypto Wallet: Hardware wallet transactions failing in queue #10812

Open lukemulks opened 4 years ago

lukemulks commented 4 years ago

Description

I've attempted to make a few transactions from my hardware wallet (Ledger Nano S) today, and have run into some issues (and have some questions).

Ledger was connected and in an active state.

All transactions generated etherscan https://etherscan.io/tx/undefined links in the transaction queue. I run into these sometimes with other wallets when I attempt to view the tx too soon after initiated (prior to confirmations), but in this case it still appears to be undefined hours after the transaction was initiated.

Additionally, I'm not sure if this is intended behavior, but even after I disconnect my hardware wallet, the account still displays among my Crypto Wallet accounts, and Brave does not prevent me from making transactions with the hardware wallet (even when the wallet is disconnected). Unclear if this is intended, or if I should expect to see this account removed automatically when the hardware wallet is physically disconnected from the device.

Steps to Reproduce

  1. Connect Ledger Nano S (address type: Legacy (MEW/MyCrypto)
  2. Attempt to make an ERC20 token transaction
  3. Get stuck in queue

to repro the hardware wallet account persisting in available accts view after disconnecting:

  1. connect ledger nano S (address type: legacy)
  2. disconnect hardware wallet.
  3. switch to other acct.
  4. switch back to hardware wallet acct. observe active wallet data.
  5. make an erc20 token transaction. Brave will show in queue.

Actual result:

Expected result:

Transactions should be successfully executed - was using the fast gas option.

Reproduces how often:

100% of the time for me.

Brave version (brave://version info)

Brave | 1.12.87 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Linux

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

srirambv commented 4 years ago

cc: @ryanml

kaiba42 commented 4 years ago

any progress on this?